Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: twitter card #80

Merged
merged 8 commits into from
Feb 17, 2021
Merged

feat: twitter card #80

merged 8 commits into from
Feb 17, 2021

Conversation

farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Feb 17, 2021 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Create remark plugin to fetch tweets generate tweet card. (Using remark plugin will help us to better caching strategy)

I've created a temporary page to demo and support edge cases. Demo

resolves #19

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Feb 17, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/r9sh8rc10
✅ Preview: https://docus-git-tweet.nuxtlabs.vercel.app

@atinux Volta.net
Copy link
Contributor

atinux commented Feb 17, 2021

I left a code comment :)

@farnabaz farnabaz marked this pull request as ready for review February 17, 2021 13:00
@farnabaz farnabaz requested a review from atinux February 17, 2021 13:00
@atinux
Copy link
Contributor

atinux commented Feb 17, 2021

It is looking good, I think we shall document the Tweet component into https://docus-git-tweet.nuxtlabs.vercel.app/usage/components with on example and remove the tweets page now :)

We can use this tweet to embed: https://twitter.com/nuxt_js/status/1314628331841761289

@farnabaz
Copy link
Collaborator Author

Updated

@atinux
Copy link
Contributor

atinux commented Feb 17, 2021

One conflict to fix and ready to merge :)

@farnabaz
Copy link
Collaborator Author

Updated

@atinux atinux merged commit 060361b into main Feb 17, 2021
@Tahul Tahul deleted the tweet branch April 14, 2021 10:30
Tahul added a commit that referenced this pull request Apr 20, 2022
@pi0 @Tahul
fix: update nuxtApp usage (#80)
6a68d90 
Co-authored-by: Yaël GUILLOUX <[email protected]>
Tahul pushed a commit that referenced this pull request Apr 20, 2022
@renovate @renovate-bot
chore(deps): update all non-major dependencies (#80)
2f6456c 
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux Awaiting requested review from atinux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed Tweets with great performances
2 participants
@farnabaz @atinux